Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sendgrid Audiences] - adding user attribute and custom field support #2604

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Nov 19, 2024

Adding user attribute and custom_field support for Sendgrid Audience Destination.

Testing

Unit test added. Tested locally.
Not in use by customers yet.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (38940ff) to head (b7c59ef).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../sendgrid-audiences/syncAudience/dynamic-fields.ts 16.66% 10 Missing ⚠️
...tinations/sendgrid-audiences/syncAudience/utils.ts 66.66% 1 Missing and 3 partials ⚠️
...tinations/sendgrid-audiences/syncAudience/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2604      +/-   ##
==========================================
- Coverage   78.57%   78.51%   -0.06%     
==========================================
  Files        1027     1028       +1     
  Lines       18121    18147      +26     
  Branches     3416     3422       +6     
==========================================
+ Hits        14238    14249      +11     
- Misses       2748     2760      +12     
- Partials     1135     1138       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment joe-ayoub-segment changed the title [Sendgrid Audiences] - adding user attribute support [Sendgrid Audiences] - adding user attribute and custom field support Nov 19, 2024
itsarijitray
itsarijitray previously approved these changes Nov 20, 2024
@joe-ayoub-segment joe-ayoub-segment merged commit b31888c into main Nov 26, 2024
13 of 15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the sendgridAudienceEnhancements branch November 26, 2024 13:07
@joe-ayoub-segment
Copy link
Contributor Author

We're in a deploy freeze so next deploy scheduled for 3-Dec

@joe-ayoub-segment
Copy link
Contributor Author

deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants