-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sendgrid Audiences] - adding user attribute and custom field support #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 78.57% 78.51% -0.06%
==========================================
Files 1027 1028 +1
Lines 18121 18147 +26
Branches 3416 3422 +6
==========================================
+ Hits 14238 14249 +11
- Misses 2748 2760 +12
- Partials 1135 1138 +3 ☔ View full report in Codecov by Sentry. |
joe-ayoub-segment
changed the title
[Sendgrid Audiences] - adding user attribute support
[Sendgrid Audiences] - adding user attribute and custom field support
Nov 19, 2024
itsarijitray
previously approved these changes
Nov 20, 2024
sayan-das-in
approved these changes
Nov 26, 2024
We're in a deploy freeze so next deploy scheduled for 3-Dec |
deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding user attribute and custom_field support for Sendgrid Audience Destination.
Testing
Unit test added. Tested locally.
Not in use by customers yet.