First push with CustomEvents Destination Action

[wtnelso]

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

• Added unit tests for new functionality
• Tested end-to-end using the local server
• [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
• [Segmenters] Tested in the staging environment
• [Segmenters] [If applicable for this change] Tested for regression with Hadron.

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[joe-ayoub-segment]

Hi @wtnelso thanks for raising this PR!
I'll schedule some time to review.

Could you please remove the yarn version upgrade please?
The PR contains changes to the package.json and yarn.lock files, which looks like it might have been a mistake.

[joe-ayoub-segment]

Please add this default mapping for phone:

default: {
        '@if': {
          exists: { '@path': '$.properties.phone' },
          then: { '@path': '$.properties.phone' },
          else: { '@path': '$.context.traits.phone' }
        }
}

[wtnelso]

added to the file and committed.

[joe-ayoub-segment]

hi @wtnelso I just went through the code and would like to make some changes to make the UI simpler. Do you mind granting me permission to push changes to your repo please? joe-ayoub-segment is my Github handle.

[joe-ayoub-segment]

hi @wtnelso just following up on this. Are you still interested in having these changes deployed?

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[joe-ayoub-segment]

hi @wtnelso
Would you be able to schedule a call with me so we can fix up this Destination and get it deployed please?
Here's my Calendly: https://calendly.com/joe_ayoub/

I look forward to catching up.
Joe

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[wtnelso]

Hi @joe-ayoub-segment, i added a new unit test. other than that new one, not sure there are others to add.

One more question. I used the command yarn cloud test packages/destination-actions/src/destinations/attentive and get the below and then following error. Is there anything I need to do different next time?

Is there something else I need to configure on my end?

[joe-ayoub-segment]

Hi @wtnelso - which folder did you execute the command from? You should be in the repo root folder.

[wtnelso]

@joe-ayoub-segment I've tried at the attentive folder and its sub folder. packages/destination-actions/src/destinations/attentive

besides this one command, are there other changes needed for this PR? If we're good on this one, I'll begin the work on the other endpoints we want to add next

[joe-ayoub-segment]

Hi @wtnelso - the new test doesn't work.
No probs though, just leave it. I'll fix or remove it.
Feel free to work on the other Actions.

[wtnelso]

@joe-ayoub-segment great, and thank you. please let me know if anything else is needed for this PR.

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[joe-ayoub-segment]

Hi @wtnelso I've prepared this PR for deploy.
If you are going to write any more code (for the other Actions) please do them in a separate branch.

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[joe-ayoub-segment]

We're in a deploy freeze so next deploy scheduled for 3-Dec

[joe-ayoub-segment]

hi @wtnelso this PR has been deployed. I'll email you next steps.