Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Faulty Test cases #2538

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix Faulty Test cases #2538

merged 1 commit into from
Oct 28, 2024

Conversation

itsarijitray
Copy link
Contributor

@itsarijitray itsarijitray commented Oct 28, 2024

Summary

Fixing faulty hyperengage tests in actions

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (811d006) to head (aee8326).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2538      +/-   ##
==========================================
- Coverage   78.51%   78.00%   -0.52%     
==========================================
  Files        1044      991      -53     
  Lines       20029    17388    -2641     
  Branches     3988     3281     -707     
==========================================
- Hits        15726    13563    -2163     
+ Misses       3209     2737     -472     
+ Partials     1094     1088       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsarijitray itsarijitray changed the title Fix Test cases Fix Faulty Test cases Oct 28, 2024
@itsarijitray itsarijitray merged commit dda2c53 into main Oct 28, 2024
14 of 15 checks passed
@itsarijitray itsarijitray deleted the test/hyperengage-fix branch October 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants