[STRATCONN-4294] | Add MultiStatusResponse to AddProfileToList of Klaviyo. #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
==========================================
+ Coverage 78.41% 78.43% +0.02%
==========================================
Files 1030 1030
Lines 18315 18343 +28
Branches 3469 3472 +3
==========================================
+ Hits 14362 14388 +26
+ Misses 2800 2799 -1
- Partials 1153 1156 +3 ☔ View full report in Codecov by Sentry. |
added 2 commits
October 29, 2024 14:53
packages/destination-actions/src/destinations/klaviyo/properties.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/__tests__/multistatus.test.ts
Show resolved
Hide resolved
varadarajan-tw
previously approved these changes
Nov 19, 2024
varadarajan-tw
previously approved these changes
Dec 6, 2024
itsarijitray
previously approved these changes
Dec 6, 2024
added 2 commits
December 12, 2024 20:13
varadarajan-tw
approved these changes
Dec 12, 2024
| multiStatusResponse.setSuccessResponseAtIndex(validPayloadIndicesBitmap[index], { | ||
| status: 200, | ||
| sent: payload, | ||
| body: JSON.stringify(response?.data) |
There was a problem hiding this comment.
nit: Why do we have to Stringify? Could we directly set response?.data?
|
PR deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
This pull request aims to add multiStatusResponse batch support for the AddProfileToList action of Klaviyo(Actions).
Local & Stage Testing Documentation
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.