Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip don't review][LinkedIn CAPI] Better flow when configuring conversion rule #2174

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nick-Ag
Copy link
Member

@nick-Ag nick-Ag commented Jul 12, 2024

This PR adds an 'operation' field to the LinkedIn CAPI conversion rule selection flow. Based on the user selection in that dropdown, relevant fields are then shown.

Testing

Tested successfully by pushing to stage

Screen.Recording.2024-07-12.at.2.30.11.PM.mov
  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

nick-Ag added 2 commits July 12, 2024 14:03
…r. Introduces conditions based on that condition where we will only show relevant fields based on the users input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants