Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Fields V2 - Conditionally Required Fields #2099

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Required Fields V2 - Conditionally Required Fields #2099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
eb1fd29
PoC for direct builder defined JSON Schema with working unit test
nick-Ag Jun 14, 2024
f3d7f78
Adds more unit tests
nick-Ag Jun 15, 2024
18eae5d
Renames definition.validSchema to definition.groupConditions and rest…
nick-Ag Jun 15, 2024
4ac8c4b
WIP - implementation of DependsOnConditions conversion to JsonSchema
nick-Ag Jun 15, 2024
bf89d62
Merge branch 'main' into required-fields-v2
nick-Ag Nov 8, 2024
06d689e
Generates a basic schema. Passes basic test case
nick-Ag Nov 13, 2024
5e1c154
More unit tests, non-passing
nick-Ag Nov 14, 2024
91f3a01
Merge remote-tracking branch 'origin/main' into required-fields-v2
nick-Ag Nov 14, 2024
b5fbb2c
Able to generate schema when there are multiple conditions on one fie…
nick-Ag Nov 15, 2024
80148b2
WIP - unit tests
nick-Ag Nov 18, 2024
1bc68c1
WIP - two cases failing, not from an incorrectly created schema
nick-Ag Nov 21, 2024
6c3e51e
All test cases for multiple conditions on same field passing
nick-Ag Nov 21, 2024
4048746
Can validate a basic object dependency
nick-Ag Nov 21, 2024
0593689
Can validate a basic object dependency with an is_not operator
nick-Ag Nov 21, 2024
933a18c
Adds more object test cases
nick-Ag Nov 22, 2024
a677f43
Adds unit tests for different value data types
nick-Ag Nov 22, 2024
49812e3
Can validate simple conditions with undefined values
nick-Ag Nov 22, 2024
7b7d767
Adds new unit tests for multiple conditions with an undefined value. …
nick-Ag Nov 22, 2024
2329819
Some helper methods and DRYing
nick-Ag Nov 23, 2024
30a3ad5
WIP - only test object case
nick-Ag Dec 2, 2024
b1704f5
WIP - renames helper method to be more descriptive
nick-Ag Dec 2, 2024
f8a7c26
WIP - enable all unit tests
nick-Ag Dec 2, 2024
78a1e69
WIP - factors out singleConditionSingleDependency case
nick-Ag Dec 2, 2024
700f967
WIP - factors out singleConditionSingleDependency case
nick-Ag Dec 2, 2024
d1d2773
WIP - simplifies multiple non-object case
nick-Ag Dec 2, 2024
8e75171
WIP - simplifies multiple object case. actually passes multiple: true…
nick-Ag Dec 2, 2024
8caebae
Removes commented out code
nick-Ag Dec 2, 2024
b41424b
Fixed incorrect test case, all test cases passing
nick-Ag Dec 2, 2024
d4f036a
Removes 3 year old todo unit test
nick-Ag Dec 2, 2024
e73ec64
Removes groupConditions as they'll be implemented in a separate PR
nick-Ag Dec 2, 2024
f8a0558
Renames fields-to-jsonschema file to indicate it only contains snapsh…
nick-Ag Dec 2, 2024
f48807d
Merge branch 'main' into required-fields-v2
nick-Ag Dec 2, 2024
c8f0490
Removes dedicated snapshot tests and just makes all existing tests al…
nick-Ag Dec 2, 2024
488753e
Skips conditions when generating types for the stored file
nick-Ag Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading