Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Strat-3157] | Updated type of num_items from string to integer #1620

Merged
merged 3 commits into from
Oct 3, 2023
Merged

[Strat-3157] | Updated type of num_items from string to integer #1620

merged 3 commits into from
Oct 3, 2023

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Sep 28, 2023 •
edited
Loading

This Pull request is to update the num_items from string to integer to fix this issue

Screenshot 2023-09-29 at 1 11 44 PM Screenshot 2023-10-03 at 1 28 28 PM

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment - Not required

@Innovative-GauravKochar Innovative-GauravKochar changed the title [Strat-3157] | Pinterest Conversions API - Sending num_items in API as integer. [Strat-3157] | Sending num_items in Pinterest Conversions API as integer. Sep 28, 2023
@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review September 29, 2023 06:28
@Innovative-GauravKochar Innovative-GauravKochar requested a review from a team as a code owner September 29, 2023 06:28
@Innovative-GauravKochar Innovative-GauravKochar changed the title [Strat-3157] | Sending num_items in Pinterest Conversions API as integer. [Strat-3157] | Updated type of num_items from string to integer Oct 3, 2023
@varadarajan-tw
Copy link
Contributor

Approving this PR. Type change should be safe given the number of users who are using this field is less and even for them, it is not working.

@Innovative-GauravKochar Innovative-GauravKochar merged commit ec2edbd into main Oct 3, 2023
@Innovative-GauravKochar Innovative-GauravKochar deleted the strat-3157 branch October 3, 2023 10:44
harsh-joshi99 added a commit that referenced this pull request Oct 12, 2023
@harsh-joshi99
Squashed commit of the following:
8937304 
commit 8b736ac
Author: Harsh Joshi <[email protected]>
Date:   Thu Oct 12 10:12:51 2023 +0530

    Add order complete action to klaviyo

commit e440b74
Author: Harsh Joshi <[email protected]>
Date:   Tue Oct 10 15:32:10 2023 +0530

    Add upsert profile and track event actions to klaviyo

commit 5a1cb53
Author: Joe Ayoub <[email protected]>
Date:   Mon Oct 9 18:16:38 2023 +0200

    updating wording on field (#1631)

commit 2f16bc8
Author: Ankit Gupta <[email protected]>
Date:   Mon Oct 9 19:45:54 2023 +0530

    Revert "[STRATCONN] 3183 Added email subscribe as dynamic field in braze (#1606)" (#1639)

    This reverts commit 17bd01f.

commit 34fbab6
Author: Elena <[email protected]>
Date:   Thu Oct 5 13:06:00 2023 -0700

    Yahoo audiences 2 (#1636)

    * scaffold files and folders
    * updated yahoo integration
    * Comments and some fixes.
    * Updating definition to have `createSegment` action.
    * modified mappings
    * updateStatus fix
    * Added new action createCustomerNode

    Code clean up, extra console.logs for testing

    * Yahoo: prep for Staging
    * Yahoo: minor fixes
    * Yahoo: gdpr support
    * Yahoo: added validation that incoming event is Audience update, removed unnecessary logging
    * Removing repeated code, improving JSDoc.
    * Unifying `updateTaxonomy` calls.
    * - `await/try/catch` instead of chained promises;
    - Missing `BASE_URL` as constant.

    * Yahoo: added createAudience, testAuthentication, updated settings
    * Yahoo: async func call fix
    * attempting to get project to build
    * registering yahoo-audiences
    * Adding Destination description
    * Adding missing description to Action
    * Setting enable_batching field to be boolean
    * Setting enable_batching setting to be boolean
    * Yahoo: handling errors from taxonomy API
    * Yahoo: modifier err handling
    * Unit test for `YahooAudiences.updateSegment`.
    * Success and failure cases for `YahooAudiences.updateSegment`.
    * Unit tests for `createAudience` in Yahoo Audiences.
    * Yahoo: removed duplicate file
    * Yahoo: updateSegment action changes - added Identifier selector, Yahoo payload checks, set action fields 'required' status to false where needed
    * Yahoo: updated audienceSettings
    * Yahoo: added more unit tests, added support of preferred identifier in 'audienceSettings' with a fallback to an identifier fetched from the action
    * Yahoo: added check of audience_id
    * Fixing unit tests.
    * Yahoo: minor fixes
    * Yahoo: cleaned up comments, console.log
    * Snapshots don't make sense here: we have two endpoints. One of them uses OAuth1, which gets a new nonce every time the API is called.
    * Removing unnecessary `else`s.
    * Yahoo: Taxonomy API auth change
    * Yahoo: unit tests
    * deleting actions

    ---------

    Co-authored-by: Jina Park <[email protected]>
    Co-authored-by: Elena Parshina <[email protected]>
    Co-authored-by: Leonel Sanches <[email protected]>
    Co-authored-by: joe-ayoub-segment <[email protected]>

commit 4b31c5b
Author: rhall-twilio <[email protected]>
Date:   Thu Oct 5 11:33:54 2023 -0400

    remove timestamp from LiveRamp filename default (#1633)

commit fa3afde
Author: joe-ayoub-segment <[email protected]>
Date:   Tue Oct 3 15:23:55 2023 +0100

    Publish

     - @segment/[email protected]

commit f3c9b8c
Author: Joe Ayoub <[email protected]>
Date:   Tue Oct 3 16:22:13 2023 +0200

    Registering hyperengage

    Registering hyperengage Destination

commit 3ef6f30
Author: Ryan Rouleau <[email protected]>
Date:   Tue Oct 3 09:23:31 2023 -0400

    Track s3 call (#1600)

commit b984363
Author: Elena <[email protected]>
Date:   Tue Oct 3 06:16:59 2023 -0700

    Yahoo audiences (#1628)

    * scaffold files and folders

    * updated yahoo integration

    * Comments and some fixes.

    * Updating definition to have `createSegment` action.

    * modified mappings

    * updateStatus fix

    * Added new action createCustomerNode

    Code clean up, extra console.logs for testing

    * Yahoo: prep for Staging

    * Yahoo: minor fixes

    * Yahoo: gdpr support

    * Yahoo: added validation that incoming event is Audience update, removed unnecessary logging

    * Removing repeated code, improving JSDoc.

    * Unifying `updateTaxonomy` calls.

    * - `await/try/catch` instead of chained promises;
    - Missing `BASE_URL` as constant.

    * Yahoo: added createAudience, testAuthentication, updated settings

    * Yahoo: async func call fix

    * attempting to get project to build

    * registering yahoo-audiences

    * Adding Destination description

    * Adding missing description to Action

    * Setting enable_batching field to be boolean

    * Setting enable_batching setting to be boolean

    * Yahoo: handling errors from taxonomy API

    * Yahoo: modifier err handling

    * Unit test for `YahooAudiences.updateSegment`.

    * Success and failure cases for `YahooAudiences.updateSegment`.

    * Unit tests for `createAudience` in Yahoo Audiences.

    * Yahoo: removed duplicate file

    * Yahoo: updateSegment action changes - added Identifier selector, Yahoo payload checks, set action fields 'required' status to false where needed

    * Yahoo: updated audienceSettings

    * Yahoo: added more unit tests, added support of preferred identifier in 'audienceSettings' with a fallback to an identifier fetched from the action

    * Yahoo: added check of audience_id

    * Fixing unit tests.

    * Yahoo: minor fixes

    * Yahoo: cleaned up comments, console.log

    * Snapshots don't make sense here: we have two endpoints. One of them uses OAuth1, which gets a new nonce every time the API is called.

    * removing unnecessary and possibly problematic error throw

    ---------

    Co-authored-by: Jina Park <[email protected]>
    Co-authored-by: Elena Parshina <[email protected]>
    Co-authored-by: Leonel Sanches <[email protected]>
    Co-authored-by: joe-ayoub-segment <[email protected]>

commit 17a2f7f
Author: suppalapati <[email protected]>
Date:   Tue Oct 3 05:49:20 2023 -0700

    fix: remove eventstreams flagon (#1622)

    Co-authored-by: suppalapati <[email protected]>

commit dc0f000
Author: zhadier39 <[email protected]>
Date:   Tue Oct 3 17:48:57 2023 +0500

    [Hyperengage] Destination (#1621)

    * Add unit and integration tests

    * Updated field descriptions for group, identify and track

    * Updated common fields

    * Fix identify function error

    * Added authentication endpoint

    * Revise tests to enable auth

    * Update default paths for groupId.

    * Implement recommended changes from PR #1621

    * Add url field

    * Resolve pathing issues and add tests/checks for first and last name fields

    * Resolve test issues, payload validation error, and correct context default

    ---------

    Co-authored-by: saadhypng <[email protected]>
    Co-authored-by: Saad Ali <[email protected]>

commit 08e75ef
Author: Matt Grosvenor <[email protected]>
Date:   Tue Oct 3 06:47:18 2023 -0400

    Segment Actions Improvements (#23) (#1550)

    * Make userId and uid not required

    * Change path from v2beta to v2

    * Remove integrationSrc query param for v2 routes

    * change testAuthentication to use /me endpoint

commit ec2edbd
Author: Innovative-GauravKochar <[email protected]>
Date:   Tue Oct 3 16:14:22 2023 +0530

    [Strat-3157] | Updated type of num_items from string to integer (#1620)

    * worked on fixing 3157 | Pinterest Conversions API sending integers as strings.

    * Handle NAN while parsing

    * updated datatype of num_items from string to integer

    ---------

    Co-authored-by: Gaurav Kochar <[email protected]>

commit a008da0
Author: Maryam Sharif <[email protected]>
Date:   Mon Oct 2 11:29:44 2023 -0700

    Publish

     - @segment/[email protected]
     - @segment/[email protected]
     - @segment/[email protected]
     - @segment/[email protected]
     - @segment/[email protected]

commit 3c89f00
Author: maryamsharif <[email protected]>
Date:   Mon Oct 2 11:22:21 2023 -0700

    [The Trade Desk] Add error message (#1627)

    * Add error if external_id not found in payload

    * Add test case

    * Add preset

    * Remove preset:

commit af521a0
Author: maryamsharif <[email protected]>
Date:   Mon Oct 2 10:54:39 2023 -0700

    [TikTok Audiences] Remove feature flag (#1624)

    * Use different feature flag

    * Fix test

    * Remove feature flag

commit 53f6f86
Author: maryamsharif <[email protected]>
Date:   Mon Oct 2 10:06:32 2023 -0700

    [The Trade Desk CRM] Remove old create audience flow (#1618)

    * Remove flagon for createAudience

    * Remove unnecesssary fields

    * Fix tests

commit a24111e
Author: joe-ayoub-segment <[email protected]>
Date:   Mon Oct 2 13:33:45 2023 +0100

    comitting generated typees for hubble

commit 478b969
Author: joe-ayoub-segment <[email protected]>
Date:   Mon Oct 2 12:46:46 2023 +0100

    registering hubble

commit b60859d
Author: M.Byun <[email protected]>
Date:   Mon Oct 2 20:16:10 2023 +0900

    feat: hubble-web browser-destination (#1566)

    * feat: hubble-web browser-destination

    * refactor: change settings appId to id

    * refactor: setSource to be global and add identifiers to track

    * fix(hubble-web): set optional chaining when setting source on initialize

    * refactor: make identify and track take objects as arguments

    * fix: change to production URL for script

    * fix: failing test for hubble-web browser destination
    - change test to correct URL
    - add optional chaining to setSource on initialize

commit 17bd01f
Author: Ankit Gupta <[email protected]>
Date:   Thu Sep 28 12:48:52 2023 +0530

    [STRATCONN] 3183 Added email subscribe as dynamic field in braze (#1606)

    * Added email subscribe as dynamic field in braze

    * build failing due to generated type
wpride pushed a commit to wpride/action-destinations that referenced this pull request Oct 12, 2023
@Innovative-GauravKochar
[Strat-3157] | Updated type of num_items from string to integer (segm…
d358ce8 
…entio#1620)

* worked on fixing 3157 | Pinterest Conversions API sending integers as strings.

* Handle NAN while parsing

* updated datatype of num_items from string to integer

---------

Co-authored-by: Gaurav Kochar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varadarajan-tw varadarajan-tw varadarajan-tw approved these changes

Assignees
No one assigned
Labels
not-partner-eng-review (cloud)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Innovative-GauravKochar @varadarajan-tw @joe-ayoub-segment