Channels-973: parse text field of action buttons (#1738)

* feat: parse merge tags in action button text * chore: added unit test
segmentio · Nov 29, 2023 · 31e207c · 31e207c
1 parent 593b024
commit 31e207c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...ges/destination-actions/src/destinations/engage/twilio/__tests__/send-mobile-push.test.ts b/...ges/destination-actions/src/destinations/engage/twilio/__tests__/send-mobile-push.test.ts
@@ -350,7 +350,7 @@ describe('sendMobilePush action', () => {
       expect(responses[0].data).toMatchObject(externalIds[0])
     })
 
-    it('parses links in tapActionButtons', async () => {
+    it('parses links and titles in tapActionButtons', async () => {
       const title = 'buy'
       const body = 'now'
       const tapAction = 'OPEN_DEEP_LINK'
@@ -365,7 +365,7 @@ describe('sendMobilePush action', () => {
         tapActionButtons: [
           {
             id: '1',
-            text: 'open',
+            text: 'open{{profile.traits.fav_color}}',
             onTap: 'deep_link',
             link: 'app://buy-now/{{profile.traits.fav_color}}'
           },
@@ -414,7 +414,7 @@ describe('sendMobilePush action', () => {
           tapActionButtons: [
             {
               id: '1',
-              text: 'open',
+              text: 'openmantis_green',
               onTap: 'deep_link',
               link: 'app://buy-now/mantis_green'
             },

diff --git a/packages/destination-actions/src/destinations/engage/twilio/sendMobilePush/PushSender.ts b/packages/destination-actions/src/destinations/engage/twilio/sendMobilePush/PushSender.ts
@@ -120,7 +120,7 @@ export class PushSender extends TwilioMessageSender<PushPayload> {
         return {
           ...button,
           onTap: this.getTapActionPreset(button.onTap, button.link),
-          ...(await this.parseContent({ link: button.link }, profile))
+          ...(await this.parseContent({ link: button.link, text: button.text }, profile))
         }
       })
     )