Skip to content
This repository has been archived by the owner on Nov 23, 2019. It is now read-only.

Handle 429 and 5xx HTTP errors #48

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Handle 429 and 5xx HTTP errors #48

merged 2 commits into from
Aug 28, 2018

Conversation

fathyb
Copy link
Contributor

@fathyb fathyb commented Aug 24, 2018

Currently, our retry implementations only retries on network errors, it doesn't handle HTTP errors.


Ref: LIB-515

@fathyb fathyb requested a review from f2prateek August 24, 2018 14:35
@f2prateek
Copy link
Contributor

I think we want to not retry on 4xx errors (except 429, where we should retry).

From the guidelines:

In general, the retry strategy should be kept simple:

1. Retry network errors (socket timed out, etc.)
2. Retry server errors (HTTP 5xx)
3. Do not retry client errors (HTTP 4xx)
  1. Except HTTP 429.

@fathyb fathyb changed the title Handle 4xx and 5xx HTTP errors Handle 429 and 5xx HTTP errors Aug 28, 2018
@fathyb
Copy link
Contributor Author

fathyb commented Aug 28, 2018

thanks @f2prateek! it's fixed

@f2prateek
Copy link
Contributor

Thanks. LGTM! Can you write up a CC ticket?

@fathyb
Copy link
Contributor Author

fathyb commented Aug 28, 2018

@fathyb fathyb merged commit 963737e into master Aug 28, 2018
@fathyb fathyb deleted the fix/handle-4xx-and-5xx branch August 28, 2018 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants