-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show mentees under the mentor profile #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sef-global#150 Fix lint issues
Madhawa97
force-pushed
the
Madhawa97/issue150
branch
from
August 9, 2024 14:44
c25e3f5
to
5c84bb3
Compare
It's not just the profile picture. A mentee card should be shown just like we show for the mentors. @Madhawa97 clicking a mentee card should redirect to a public mentee page |
Madhawa97
force-pushed
the
Madhawa97/issue150
branch
from
August 10, 2024 11:59
1d083d4
to
f080523
Compare
Madhawa97
force-pushed
the
Madhawa97/issue150
branch
from
August 10, 2024 12:03
f080523
to
fde40d1
Compare
Madhawa97
requested review from
anjula-sack
and removed request for
anjula-sack
August 12, 2024 17:44
anjula-sack
requested changes
Aug 14, 2024
anjula-sack
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! @Madhawa97
Thanks! @anjula-sack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #150, #151
Goals
Show mentees under the mentor profile
Approach
Show mentees of a mentor as a avatar stack.
Screenshots
Checklist
Related PRs
Test environment
Learning