Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show mentees under the mentor profile #152

Merged
merged 7 commits into from
Aug 17, 2024

Conversation

Madhawa97
Copy link
Member

@Madhawa97 Madhawa97 commented Aug 9, 2024

Purpose

The purpose of this PR is to fix #150, #151

Goals

Show mentees under the mentor profile

Approach

Show mentees of a mentor as a avatar stack.

Screenshots

image
image

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Madhawa97 Madhawa97 force-pushed the Madhawa97/issue150 branch from c25e3f5 to 5c84bb3 Compare August 9, 2024 14:44
@Madhawa97 Madhawa97 marked this pull request as ready for review August 9, 2024 14:49
@Madhawa97 Madhawa97 requested a review from anjula-sack August 9, 2024 14:49
@anjula-sack
Copy link
Member

It's not just the profile picture. A mentee card should be shown just like we show for the mentors. @Madhawa97 clicking a mentee card should redirect to a public mentee page

@Madhawa97 Madhawa97 requested review from anjula-sack and removed request for anjula-sack August 12, 2024 17:44
src/components/ProfilePic/index.tsx Outdated Show resolved Hide resolved
@Madhawa97 Madhawa97 requested a review from anjula-sack August 15, 2024 13:10
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @Madhawa97

@anjula-sack anjula-sack merged commit b821f31 into sef-global:main Aug 17, 2024
3 checks passed
@Madhawa97
Copy link
Member Author

Thanks! @anjula-sack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show mentees under the mentor profile
2 participants