Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docker image usage to README.md #1

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Conversation

seemethere
Copy link
Owner

Signed-off-by: Eli Uriegas [email protected]

Copy link

@jose-bigio jose-bigio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@corbin-coleman corbin-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image exists:

$ docker pull seemethere/unir:latest

Usage is as follows:

```
docker run -d -e UNIR_WEBHOOK_SECRET -e UNIR_CLIENT_TOKEN -p 8080:8080 seemethere/unir:latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you add -it to the command?
What about removing the extra line in the README?

In reviewing I did see that the image was there!

@botmethere botmethere merged commit 4593d7e into master Jan 17, 2018
@seemethere seemethere deleted the add_docker_image_readme branch January 17, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants