Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MimeMagic is incorrectly detecting XLSX files as application/zip #1820

Closed
stuzart opened this issue Apr 9, 2024 · 0 comments
Closed

MimeMagic is incorrectly detecting XLSX files as application/zip #1820

stuzart opened this issue Apr 9, 2024 · 0 comments
Assignees
@stuzart
Milestone
1.15.2

Comments

@stuzart
Copy link
Member

stuzart commented Apr 9, 2024 •
edited
Loading

Not entirely sure why, I have the latest shared-mime-info package installed. Some if not all XLXS files are being detected as application/zip when double checked through mime magic.

It makes use of the mimemagic gem, and it's this gem that is incorrectly returning the incorrect type.

This cropped up with out of memory errors when trying to explore a largish spreadsheet. When there is an error there is step to double check and update the mime type.

the mimemagic gem is no longer actively supported, and ActiveStorage now uses Marcel, which I've tested and checked it responds with the correct mimetype.
@stuzart stuzart added this to the v1.15.0 milestone Apr 9, 2024
@stuzart stuzart self-assigned this Apr 9, 2024
stuzart added a commit that referenced this issue Apr 9, 2024
@stuzart
start switching to marcel #1820
cdce974
stuzart added a commit that referenced this issue Apr 11, 2024
@stuzart
remove the double checking and updating of the mime type #1820
c3f8b2c
@stuzart stuzart mentioned this issue Apr 15, 2024
Merged
stuzart added a commit that referenced this issue Apr 16, 2024
@stuzart
remove the double checking and updating of the mime type #1820
35a7c8b
@stuzart stuzart closed this as completed Apr 16, 2024
kdp-cloud pushed a commit to ELIXIR-Belgium/seek that referenced this issue Apr 19, 2024
@stuzart @kdp-cloud
remove the double checking and updating of the mime type seek4science…
8a3ace6 
…#1820
kdp-cloud pushed a commit to ELIXIR-Belgium/seek that referenced this issue May 8, 2024
@stuzart @kdp-cloud
remove the double checking and updating of the mime type seek4science…
f7f016c 
…#1820
stuzart added a commit that referenced this issue Jul 1, 2024
@stuzart
stop the double checking of mime type if csv or xml extraction fails.…
6954ee2 
… relates to #1820
stuzart added a commit that referenced this issue Jul 4, 2024
@stuzart
remove the double checking and updating of the mime type #1820
3356736
@stuzart stuzart modified the milestones: v1.15.0, 1.15.2 Jul 4, 2024
stuzart added a commit that referenced this issue Jul 18, 2024
@stuzart
upgrade task to repair xlsx blobs changed to zip #1820
e3ece32
@stuzart stuzart mentioned this issue Jul 18, 2024
Merged
stuzart added a commit that referenced this issue Jul 18, 2024
@stuzart
upgrade task to repair xlsx blobs changed to zip #1820
40f8650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuzart stuzart

Labels
None yet
Projects
SEEK 1.15.x
Status: Done
Milestone
1.15.2
Development

No branches or pull requests
1 participant
@stuzart