Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharing permissions to Sample Type #1199

Closed
rabuono opened this issue Oct 12, 2022 · 3 comments · Fixed by #1953
Closed

Add sharing permissions to Sample Type #1199

rabuono opened this issue Oct 12, 2022 · 3 comments · Fixed by #1953
Assignees
Milestone

Comments

@rabuono
Copy link
Collaborator

rabuono commented Oct 12, 2022

As a User I would like to attribute different levels of permission to a Sample Type so that different members of my team can view, edit, or manage it.
Sample Type sharing permissions are independent of Samples sharing permissions.

Outcome of Samples WG and part of discussion #1118

@rabuono
Copy link
Collaborator Author

rabuono commented Nov 18, 2022

Based on Samples WG discussion
Add sharing permission to sample type, as for every other item:

  • Retrospectively, it will be set to follow project default permission
  • Not an optional feature to be on/off from admin pane

floradanna added a commit that referenced this issue Apr 21, 2023
documentation for issues #1199 , #1257 , #1258
stuzart pushed a commit that referenced this issue May 16, 2023
documentation for issues #1199 , #1257 , #1258
@stuzart stuzart added this to the v1.15.0 milestone Jul 5, 2023
@rabuono rabuono added this to DataHub Jul 14, 2023
@rabuono rabuono moved this to Todo in DataHub Jul 14, 2023
@floradanna
Copy link
Collaborator

Important: Process for editing a sample type that has a linked datafile

Same process as described for the editing of samples (#1357)

Process:

  • the user goes to "edit sample type",
  • if sample type has a linked datafile, SEEK shows a warning "Sample type has been created from a datafile, editing this sample will make the datafile not valid anymore for this sample type" or something.
  • if user continue editing, the datafile link for that sample type will gain the label "not valid anymore" or something

@floradanna
Copy link
Collaborator

Scenario to be analysed: #1118 (comment)

@floradanna floradanna moved this from Todo to Backlog in DataHub Sep 14, 2023
@stuzart stuzart removed this from the v1.15.0 milestone Sep 20, 2023
@kdp-cloud kdp-cloud moved this from Backlog to In Progress in DataHub Dec 6, 2023
@kdp-cloud kdp-cloud added this to the v1.15.0 milestone Dec 19, 2023
@kdp-cloud kdp-cloud linked a pull request Jan 2, 2024 that will close this issue
@kdp-cloud kdp-cloud moved this from In Progress to Coded in DataHub Jan 2, 2024
@stuzart stuzart modified the milestones: v1.15.0, 1.15.1 Mar 19, 2024
@kdp-cloud kdp-cloud modified the milestones: 1.15.1, 1.16.0 May 8, 2024
@stuzart stuzart moved this to Backlog in SEEK 1.16.x May 15, 2024
@kdp-cloud kdp-cloud moved this from Coded to In Progress in DataHub May 27, 2024
@kdp-cloud kdp-cloud moved this from In Progress to Todo in DataHub Jul 3, 2024
@kdp-cloud kdp-cloud moved this from Todo to In Progress in DataHub Jul 3, 2024
@kdp-cloud kdp-cloud linked a pull request Jul 10, 2024 that will close this issue
@kdp-cloud kdp-cloud self-assigned this Jul 24, 2024
@kdp-cloud kdp-cloud moved this from In Progress to Coded in DataHub Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Coded to Merged in DataHub Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in SEEK 1.16.x Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants