Add warning for smt migrations

.changeset/thin-tigers-hunt.md

@@ -0,0 +1,5 @@
+---
+'skuba': patch
+---
+
+**configure:** Add notice for smt migrations

docs/migrating-from-seek-module-toolkit.md

@@ -51,6 +51,29 @@ You should remove workarounds such as:
 
 - Varying the referenced path of non-JS assets based on whether the code is source or compiled (i.e. using `__filename`).
 
+After running `skuba configure`,
+double check that the `package.json` fields look sensible.
+Expect something like this:
+
+```jsonc
+{
+  "files": ["lib*/**/*.d.ts", "lib*/**/*.js", "lib*/**/*.js.map"],
+  "main": "./lib-commonjs/index.js",
+  "main": "./lib-es2015/index.js",
+  "types": "./lib-types/index.d.ts"
+}
+```
+
+You may test out the packaging changes by either:
+
+- Pushing your changes to a `beta` Git branch, which releases a beta version on npm.
+
+  In a consuming repo, you can then `yarn install` the beta version to give it a whirl.
+
+- Locally packaging with `yarn build`, then `npm pack`.
+
+  In a consuming repo, you can then `yarn add ../path/to/package.tgz` the local version to give it a whirl.
+
 ## Formatting and linting
 
 ```shell

src/cli/configure/analyseDependencies.ts

@@ -8,7 +8,7 @@ import { TextProcessor, copyFiles } from '../../utils/copy';
 import { log } from '../../utils/logging';
 import { getSkubaVersion } from '../../utils/version';
 
-import { diffDependencies } from './analysis/package';
+import { diffDependencies, generateNotices } from './analysis/package';
 import * as dependencyMutators from './dependencies';
 import { formatPackage } from './processing/package';
 import { DependencyDiff } from './types';
@@ -72,6 +72,8 @@ export const analyseDependencies = async ({
     devDependencies: { ...input.devDependencies },
   };
 
+  const printNotices = generateNotices(input);
+
   const processors = Object.values(dependencyMutators).reduce<TextProcessor[]>(
     (acc, mutate) => {
       const newProcessors = mutate(output);
@@ -108,6 +110,8 @@ export const analyseDependencies = async ({
   log.newline();
   const hasDevDependencyDiff = logDiff(devDependencyDiff);
 
+  printNotices();
+
   const packageJsonFilepath = path.join(destinationRoot, 'package.json');
 
   if (!hasDependencyDiff && !hasDevDependencyDiff) {

src/cli/configure/analysis/package.ts

@@ -1,7 +1,7 @@
 import readPkgUp from 'read-pkg-up';
 
 import { log } from '../../../utils/logging';
-import { DependencyDiff } from '../types';
+import { DependencyDiff, DependencySet } from '../types';
 
 import { determineOperation } from './diff';
 
@@ -71,3 +71,32 @@ export const diffDependencies = (
     ...additions,
   };
 };
+
+export const generateNotices = ({
+  dependencies,
+  devDependencies,
+}: DependencySet) => {
+  if (
+    '@seek/seek-module-toolkit' in dependencies ||
+    '@seek/seek-module-toolkit' in devDependencies
+  ) {
+    return () => {
+      log.newline();
+      log.plain(`👋 Hello, ${log.bold('seek-module-toolkitter')}!`);
+      log.newline();
+      log.warn(
+        "We're going to tweak your output directories,",
+        'so double check your bundle once this is done.',
+      );
+      log.newline();
+      log.warn(
+        'Read more:',
+        log.bold(
+          'https://github.com/seek-oss/skuba/blob/master/docs/migrating-from-seek-module-toolkit.md#building',
+        ),
+      );
+    };
+  }
+
+  return () => {};
+};

src/cli/configure/dependencies/skubaDeps.ts

@@ -21,8 +21,9 @@ const DEV_DEPENDENCIES = [
   'typescript',
 ] as const;
 
-export const skubaDeps = ({ devDependencies }: DependencySet) => {
+export const skubaDeps = ({ dependencies, devDependencies }: DependencySet) => {
   DEV_DEPENDENCIES.forEach((dep) => {
+    delete dependencies[dep];
     delete devDependencies[dep];
   });
 

src/cli/configure/getEntryPoint.ts

@@ -4,6 +4,7 @@ import chalk from 'chalk';
 import { Input } from 'enquirer';
 import { NormalizedReadResult } from 'read-pkg-up';
 
+import { log } from '../../utils/logging';
 import { ProjectType } from '../../utils/manifest';
 import { TemplateConfig } from '../../utils/template';
 import { hasStringProp } from '../../utils/validation';
@@ -30,6 +31,7 @@ export const getEntryPoint = ({
     return templateConfig.entryPoint;
   }
 
+  log.newline();
   const entryPointPrompt = new Input({
     initial: type === 'package' ? 'src/index.ts' : 'src/app.ts',
     message: 'Entry point:',

src/cli/configure/getProjectType.ts

@@ -1,6 +1,7 @@
 import { Select } from 'enquirer';
 import { NormalizedReadResult } from 'read-pkg-up';
 
+import { log } from '../../utils/logging';
 import { PROJECT_TYPES, ProjectType } from '../../utils/manifest';
 import { TemplateConfig } from '../../utils/template';
 import { hasProp } from '../../utils/validation';
@@ -31,6 +32,7 @@ export const getProjectType = async ({
       ? 'package'
       : 'application';
 
+  log.newline();
   const projectTypePrompt = new Select({
     choices: PROJECT_TYPES,
     message: 'Project type:',