Require Node.js 14.18+ #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #738.
🦋 Changeset detectedLatest commit: d2ba75d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
commented
Feb 9, 2022
| @@ -11,7 +11,7 @@ const { | |||
| /** | |||
| * Set a default `src` module alias for backward compatibility. | |||
| * | |||
| * TODO: drop this default in skuba v4. | |||
| * TODO: drop this default in skuba v5. | |||
There was a problem hiding this comment.
I want to limit v4 to the Node.js 14 upgrade to ease adoption. We can investigate other breaking changes in the next major.
72636c
added a commit
that referenced
this pull request
Feb 9, 2022
We can get rid of the stack trace support in skuba-dive in favour of this Node.js CLI flag. This is stable in Node.js 14.18 which we require as of #760. - https://github.com/seek-oss/skuba-dive#register - https://nodejs.org/api/cli.html#cli_enable_source_maps Closes #399.
etaoins
approved these changes
Feb 9, 2022
Merged
72636c
added a commit
that referenced
this pull request
Feb 10, 2022
We can get rid of the stack trace support in skuba-dive in favour of this Node.js CLI flag. This is stable in Node.js 14.18 which we require as of #760. - https://github.com/seek-oss/skuba-dive#register - https://nodejs.org/api/cli.html#cli_enable_source_maps Closes #399.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738.