Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #749

Merged
merged 1 commit into from
Feb 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .changeset/big-actors-heal.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/dull-olives-doubt.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/fuzzy-bugs-act.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/gorgeous-apricots-cross.md

This file was deleted.

14 changes: 0 additions & 14 deletions .changeset/pretty-fishes-help.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/pretty-shoes-raise.md

This file was deleted.

46 changes: 0 additions & 46 deletions .changeset/shaggy-jobs-breathe.md

This file was deleted.

11 changes: 0 additions & 11 deletions .changeset/slow-lamps-listen.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/sour-insects-scream.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/strange-months-sit.md

This file was deleted.

98 changes: 98 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,103 @@
# skuba

## 4.0.0

### Major Changes

- **deps:** Require Node.js 14.18+ ([#760](https://github.com/seek-oss/skuba/pull/760))

Node.js 12 will reach end of life by April 2022. The `semantic-release` package and stable `--enable-source-maps` flag necessitate this new minimum version.

Consider upgrading the Node.js version for your project across:

- `.nvmrc`
- `package.json#/engines/node`
- CI/CD configuration (`.buildkite/pipeline.yml`, `Dockerfile`, etc.)

- **deps:** semantic-release ^19.0.0 ([#757](https://github.com/seek-oss/skuba/pull/757))

Resolves [SNYK-JS-MARKED-2342073](https://app.snyk.io/vuln/SNYK-JS-MARKED-2342073) and [SNYK-JS-MARKED-2342082](https://app.snyk.io/vuln/SNYK-JS-MARKED-2342082).

This may alleviate the following `skuba release` error:

```console
[semantic-release] › ✖ EGHNOPERMISSION The GitHub token doesn't allow to push on the repository owner/repo.
The user associated with the GitHub token (https://github.com/semantic-release/github/blob/master/README.md#github-authentication) configured in the GH_TOKEN or GITHUB_TOKEN environment variable must allows to push to the repository owner/repo.
```

- **template:** Use `--enable-source-maps` ([#761](https://github.com/seek-oss/skuba/pull/761))

Stable source map support has landed in Node.js 14.18+ via the built-in `--enable-source-maps` option.

We recommend migrating off of custom source map implementations in favour of this option. Upgrading to [**skuba-dive** v2](https://github.com/seek-oss/skuba-dive/releases/tag/v2.0.0) will remove `source-map-support` from the `skuba-dive/register` hook.

For a containerised application, update your Dockerfile:

```diff
- FROM gcr.io/distroless/nodejs:12 AS runtime
+ FROM gcr.io/distroless/nodejs:16 AS runtime

+ # https://nodejs.org/api/cli.html#cli_node_options_options
+ ENV NODE_OPTIONS --enable-source-maps
```

For a Serverless Lambda application, update your `serverless.yml`:

```diff
provider:
- runtime: nodejs12.x
+ runtime: nodejs14.x

functions:
Worker:
environment:
+ # https://nodejs.org/api/cli.html#cli_node_options_options
+ NODE_OPTIONS: --enable-source-maps
```

For a CDK Lambda application, update your stack:

```diff
new aws_lambda.Function(this, 'worker', {
- runtime: aws_lambda.Runtime.NODEJS_12_X,
+ runtime: aws_lambda.Runtime.NODEJS_14_X,
environment: {
+ // https://nodejs.org/api/cli.html#cli_node_options_options
+ NODE_OPTIONS: '--enable-source-maps',
},
});
```

### Patch Changes

- **template/lambda-sqs-worker:** Disable `tty` on deploy step ([#753](https://github.com/seek-oss/skuba/pull/753))

Serverless Framework v3 renders progress spinners on interactive terminals. We recommend disabling [tty](https://github.com/buildkite-plugins/docker-compose-buildkite-plugin#tty-optional-run-only) in CI/CD for cleaner log output.

- **template/lambda-sqs-worker:** serverless ^3.0.0 ([#748](https://github.com/seek-oss/skuba/pull/748))

- **template/lambda-sqs-worker:** Replace `custom.env` configuration with `params` ([#752](https://github.com/seek-oss/skuba/pull/752))

You can now define environment specific variables using the new Serverless parameters feature. See <https://www.serverless.com/framework/docs/guides/parameters> for more details.

- **template/\*-rest-api:** seek-jobs/gantry v1.6.1 ([#759](https://github.com/seek-oss/skuba/pull/759))

- **template/lambda-sqs-worker:** Remove `provider.lambdaHashingVersion` ([#751](https://github.com/seek-oss/skuba/pull/751))

This resolves the following deprecation warning in Serverless Framework v3:

```console
Setting "20201221" for "provider.lambdaHashingVersion" is no longer effective as new hashing algorithm is now used by default. You can safely remove this property from your configuration.
```

- **deps:** eslint-config-skuba 1.0.14 ([#758](https://github.com/seek-oss/skuba/pull/758))

This disables the `tsdoc/syntax` ESLint rule in tests for compatibility with `/** @jest-environment env */` directives.

- **deps:** isomorphic-git ^1.11.1 ([#750](https://github.com/seek-oss/skuba/pull/750))

Resolves [SNYK-JS-SIMPLEGET-2361683](https://security.snyk.io/vuln/SNYK-JS-SIMPLEGET-2361683).

## 3.17.2

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"engines": {
"node": ">=14.18"
},
"version": "3.17.2",
"version": "4.0.0",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
"files": [
Expand Down