Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file descriptor warnings #664

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Fix file descriptor warnings #664

merged 3 commits into from
Nov 11, 2021

Conversation

72636c
Copy link
Member

@72636c 72636c commented Nov 11, 2021

Resolves #659.

@72636c 72636c requested a review from a team as a code owner November 11, 2021 10:21
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2021

🦋 Changeset detected

Latest commit: 90e4b23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@samchungy samchungy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah so quick 🏃 💨

src/cli/adapter/prettier.ts Show resolved Hide resolved
src/cli/adapter/prettier.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hunting this down! I was hoping there would be a nicer fix but I’m not surprised this is the best we can do.

Are there any cases where the missing shebang detection would hurt us on a typical SEEK codebase?

Co-authored-by: Sam Chung <[email protected]>
@72636c
Copy link
Member Author

72636c commented Nov 11, 2021

@etaoins I can't imagine there would be much impact here. Shebang detection is a fallback that is only invoked where file root and extension matching have turned up empty, and the filename does not have any extension. Prettier doesn't handle typical shell scripting languages; we could possibly lose out on zx but if that picks up steam at SEEK I'm sure we can special case it in our code.

@72636c 72636c merged commit 30c519b into master Nov 11, 2021
@72636c 72636c deleted the infer-parser branch November 11, 2021 20:09
@github-actions github-actions bot mentioned this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier Warning/Errors
3 participants