-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file descriptor warnings #664
Conversation
Resolves #659.
🦋 Changeset detectedLatest commit: 90e4b23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woah so quick 🏃 💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for hunting this down! I was hoping there would be a nicer fix but I’m not surprised this is the best we can do.
Are there any cases where the missing shebang detection would hurt us on a typical SEEK codebase?
Co-authored-by: Sam Chung <[email protected]>
@etaoins I can't imagine there would be much impact here. Shebang detection is a fallback that is only invoked where file root and extension matching have turned up empty, and the filename does not have any extension. Prettier doesn't handle typical shell scripting languages; we could possibly lose out on |
Resolves #659.