Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettierignore files inside .gantry folder #636

Merged
merged 7 commits into from
Oct 31, 2021
Merged

Conversation

trevorgk
Copy link
Contributor

@trevorgk trevorgk commented Oct 28, 2021

Include additional gantry paths in the prettierignore template. The convention is to place gantry-specific yml files within .gantry folder. Add to ignore to make life easier for developers and save them the chore of manually adding to local .prettierignore

@trevorgk trevorgk requested a review from a team as a code owner October 28, 2021 04:34
@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2021

🦋 Changeset detected

Latest commit: 9fc87be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

We should probably auto-update these config files on skuba format; I'll raise an issue for that.

.changeset/tender-bugs-enjoy.md Outdated Show resolved Hide resolved
template/base/_.prettierignore Outdated Show resolved Hide resolved
@72636c 72636c changed the title fix: Prettierignore files inside .gantry folder Prettierignore files inside .gantry folder Oct 28, 2021
@72636c 72636c enabled auto-merge (squash) October 28, 2021 23:32
@72636c 72636c merged commit c994f5c into seek-oss:master Oct 31, 2021
@github-actions github-actions bot mentioned this pull request Oct 31, 2021
@trevorgk trevorgk deleted the patch-1 branch November 9, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants