Update Koa template for latest Koala #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: eb79967 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
commented
Jun 12, 2020
Comment on lines
+18
to
+23
| const setup = async () => { | ||
| await new Promise((resolve) => (server = app.listen(undefined, resolve))); | ||
| agent = request.agent(server); | ||
| }; | ||
|
|
||
| const teardown = (done: () => void) => server.close(done); | ||
| const teardown = () => new Promise((resolve) => server.close(resolve)); |
There was a problem hiding this comment.
This is mildly unrelated but I noticed it when working on Koala; the promises are a bit more modern, and it means that you can await teardown() along with other things rather than hogging Jest's done callback.
tobyhei
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.