Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node.js debugging options #230

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Support Node.js debugging options #230

merged 4 commits into from
Oct 14, 2020

Conversation

72636c
Copy link
Member

@72636c 72636c commented Oct 13, 2020

This allows you to use skuba start with IDE debuggers.

This allows you to use `skuba start` with IDE debuggers.
@72636c 72636c requested a review from a team as a code owner October 13, 2020 00:51
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2020

🦋 Changeset detected

Latest commit: 06b1158

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c 72636c requested a review from runk October 13, 2020 00:51
For example, in Visual Studio Code:

1. Run `skuba start --inspect-brk`
1. Run the built-in `Node.js: Attach` launch configuration
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this looks like

{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
  "configurations": [
    {
      "name": "Attach",
      "port": 9229,
      "request": "attach",
      "skipFiles": [
        "<node_internals>/**"
      ],
      "type": "pwa-node"
    },
  ]
}

@@ -20,6 +20,7 @@
"format": "skuba format",
"lint": "skuba lint",
"start": "skuba start",
"start:debug": "ENVIRONMENT=local skuba start --inspect-brk",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does brk make sense as the sensible default?

@72636c 72636c merged commit 4cc1a15 into master Oct 14, 2020
@72636c 72636c deleted the start-inspect branch October 14, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants