Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker-compose version autofix #1638

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Conversation

zbrydon
Copy link
Contributor

@zbrydon zbrydon commented Aug 20, 2024

#1553

Could be worth writing an autofix

🙇

@zbrydon zbrydon requested a review from a team as a code owner August 20, 2024 06:54
Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 9358484

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! If you can be bothered, it might be worth adding a couple more tests for 'lint' mode as well as rarer cases where we SHOULDN'T replace, like if there's a version: environment variable elsewhere in the file (indented)

@zbrydon zbrydon merged commit 6796f5f into main Aug 23, 2024
15 checks passed
@zbrydon zbrydon deleted the docker-compose-version-autofix branch August 23, 2024 02:01
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants