Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template/koa-rest-api: src/framework/middleware => src/framework/bodyParser #1603

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jul 2, 2024

This "middleware" file is a bit weird because we also have middleware in other files like src/framework/logging and src/framework/server.

I don't think this is worth a changeset.

…Parser

This "middleware" file is a bit weird because we also have middleware in
other files like `src/framework/logging` and `src/framework/server`.

I don't think this is worth a changeset.
@72636c 72636c requested a review from a team as a code owner July 2, 2024 03:36
Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 20d61e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we swap out the package while we're here, or stick to the popular one? koajs/bodyparser#161

@72636c 72636c merged commit 276ee20 into main Jul 2, 2024
15 checks passed
@72636c 72636c deleted the rename branch July 2, 2024 03:49
72636c added a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants