Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage .npmrc #1413

Merged
merged 18 commits into from
Feb 5, 2024
Merged

Manage .npmrc #1413

merged 18 commits into from
Feb 5, 2024

Conversation

AaronMoat
Copy link
Contributor

@AaronMoat AaronMoat commented Feb 4, 2024 •
edited
Loading

Resolves #1286

Alternative take / revival of #1305 after the new linting system is in

Should this be major? Might it break CI?

@AaronMoat AaronMoat requested review from a team as code owners February 4, 2024 06:04
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8e83c8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AaronMoat
Copy link
Contributor Author

Git isn't picking up that refreshIgnoreFiles.test.ts was a rename - can see the changes in the first commit though.

@AaronMoat
Copy link
Contributor Author

AaronMoat commented Feb 4, 2024 •
edited
Loading

Tests failing due to #1414

@AaronMoat AaronMoat requested a review from 72636c February 4, 2024 09:32
72636c
72636c reviewed Feb 4, 2024
View reviewed changes
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 code looks great, I think there's just one small niggle to cover off

.npmrc Outdated Show resolved Hide resolved
src/cli/lint/internalLints/refreshConfigFiles.ts Outdated Show resolved Hide resolved
AaronMoat
AaronMoat commented Feb 4, 2024
View reviewed changes
Copy link
Contributor Author

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of not committing all files - autofix will skip changes to npmrc (AUTOFIX_IGNORE_FILES), need to fix that (in a safe way)

72636c
72636c approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wonderful, thank you 🚀

src/cli/lint/autofix.ts Outdated Show resolved Hide resolved
src/cli/configure/upgrade/patches/7.3.1/moveNpmrcOutOfGitignoreManagedSection.ts Outdated Show resolved Hide resolved
.changeset/itchy-avocados-peel.md Outdated Show resolved Hide resolved
@AaronMoat AaronMoat merged commit 814175f into master Feb 5, 2024
18 checks passed
@AaronMoat AaronMoat deleted the manage-npmrc branch February 5, 2024 03:26
@seek-oss-ci seek-oss-ci mentioned this pull request Feb 5, 2024
Merged
@AaronMoat AaronMoat mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@72636c 72636c 72636c approved these changes

@samchungy samchungy Awaiting requested review from samchungy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage .npmrc
4 participants
@AaronMoat @samchungy @72636c @seek-oss-ci