Support pnpm #1289
Merged
Support pnpm #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zod has niceties like `.default()` that we could put to use.
🦋 Changeset detectedLatest commit: 138478a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Was not expecting a ✅ today, must be something wrong with CI! |
72636c
commented
Dec 14, 2023
| @@ -0,0 +1,6 @@ | |||
| # managed by skuba | |||
There was a problem hiding this comment.
Review that this doesn't mess with existing .npmrcs that should be ignored, as flagged in #1286.
samchungy
reviewed
Dec 18, 2023
samchungy
reviewed
Dec 18, 2023
Co-authored-by: Sam Chung <[email protected]>
Per <https://pnpm.io/cli/install>: > Inside a workspace, pnpm install installs all dependencies in all the > projects. If you want to disable this behavior, set the > recursive-install setting to false. Co-authored-by: Sam Chung <[email protected]>
Co-authored-by: Sam Chung <[email protected]>
samchungy
approved these changes
Dec 18, 2023
Co-authored-by: Sam Chung <[email protected]>
Co-authored-by: Sam Chung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1285
To do:
skuba configurecommand