Add Jest.mergePreset helper function
#126
Conversation
This concatenates array options, unlike Jest's built-in `preset` support which discards the original array elements.
🦋 Changeset is good to goLatest commit: 04d452a We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
changed the title
Jest.extends helper functionJest.extend helper function
72636c
changed the title
Jest.extend helper functionJest.preset helper
|
I like the idea but I think the name is non-obvious. Would something like |
72636c
changed the title
Jest.preset helperJest.mergePreset helper function
| type Props = Pick< | ||
| Config.InitialOptions, | ||
| | 'collectCoverage' | ||
| | 'collectCoverageFrom' | ||
| | 'collectCoverageOnlyFrom' | ||
| | 'coveragePathIgnorePatterns' | ||
| | 'coverageThreshold' | ||
| | 'globals' | ||
| | 'globalSetup' | ||
| | 'globalTeardown' | ||
| | 'setupFiles' | ||
| | 'setupFilesAfterEnv' | ||
| | 'testPathIgnorePatterns' | ||
| >; |
There was a problem hiding this comment.
@72636c Sorry to comment on an old PR, but I'm trying to understand why only a subset of jest configuration options is "Pick"ed in this type Props. Couldn't teams be given access to all Jest options? Ones that we would like to use for instance is https://jestjs.io/docs/configuration#clearmocks-boolean and https://jestjs.io/docs/configuration#resetmocks-boolean
I can definitely add those as types to the list or ignore the typescript issue in our project, just wondering the background context as to why its limited :)
There was a problem hiding this comment.
Hey @benjaminpearson! The idea was to only expose options that "safely" extend our preset and wouldn't conflict with things we'd want to manage internally now or in future. But given how long this allowlist has grown, I'm 50:50 on whether to keep extending it or just allow the full list through.
Those two look perfectly reasonable (I wonder if they could even be defaults at some point).
There was a problem hiding this comment.
This should be resolved in the next release: #798
This concatenates array options, unlike Jest's built-in
presetsupport which discards the original array elements.