Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tsx files in ESLint linting #123

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Include tsx files in ESLint linting #123

merged 2 commits into from
Jun 29, 2020

Conversation

jahredhope
Copy link
Member

The current calls for ESLint for both checking and fixing linting errors include an explicit list of extensions to check: js and ts.

An appropriately configured skuba project is able to compile tsx files to js. Typically resolving JSX to React.createElement commands. As it's possible to write and use tsx files I'd like to have eslint run over these files.

This change will include tsx in files that are checked and fixed for eslint.

@jahredhope jahredhope requested a review from a team as a code owner June 29, 2020 04:15
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2020

🦋 Changeset is good to go

Latest commit: 768757a

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c 72636c merged commit 192d7ba into master Jun 29, 2020
@72636c 72636c deleted the include-tsx-linting branch June 29, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants