Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http server support #1159

Merged
merged 5 commits into from
May 3, 2023
Merged

Add http server support #1159

merged 5 commits into from
May 3, 2023

Conversation

samchungy
Copy link
Contributor

Apollo Server 4 changed how you interact with koa and as a result you now have to export a httpServer instance.

eg. export = httpServer

https://github.com/apollo-server-integrations/apollo-server-integration-koa

image

This adds support for exporting a httpServer instance.

@samchungy samchungy requested review from a team as code owners May 3, 2023 03:30
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

🦋 Changeset detected

Latest commit: 28f0953

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@JasonZzy0528 JasonZzy0528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work👍

Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

docs/cli/run.md Outdated Show resolved Hide resolved
Co-authored-by: Ryan Ling <[email protected]>
@samchungy samchungy merged commit 800199e into master May 3, 2023
@samchungy samchungy deleted the http-server branch May 3, 2023 05:41
@seek-oss-ci seek-oss-ci mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants