Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum node version to 16.11 #1124

Merged
merged 7 commits into from
Mar 19, 2023
Merged

Bump minimum node version to 16.11 #1124

merged 7 commits into from
Mar 19, 2023

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Mar 18, 2023 •
edited
Loading

Shall we bump this now considering we're releasing a bunch of stuff anyway to avoid doing another update very soon?

@samchungy samchungy requested review from a team as code owners March 18, 2023 23:04
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 2ab5fff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

72636c
72636c reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Should we require a recent minor version?

.changeset/empty-donuts-arrive.md Outdated Show resolved Hide resolved
@samchungy samchungy changed the title Bump minimum node version to 16 Bump minimum node version to 16.11 Mar 19, 2023
72636c
72636c approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth bumping the npm-package templates to target ES2022 as well? https://github.com/search?q=repo%3Aseek-oss%2Fskuba+ES2020+language%3A%22JSON+with+Comments%22&type=code&l=JSON+with+Comments

@samchungy
Copy link
Contributor Author

samchungy commented Mar 19, 2023 •
edited
Loading

Is it worth bumping the npm-package templates to target ES2022 as well? https://github.com/search?q=repo%3Aseek-oss%2Fskuba+ES2020+language%3A%22JSON+with+Comments%22&type=code&l=JSON+with+Comments

@72636c if we do that, should we be setting explicit engine versions in the package json for those?

eg.

  "engines": {
    "node": ">=16.11"
  },

samchungy
samchungy commented Mar 19, 2023
View reviewed changes
template/private-npm-package/_package.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted the package json files

samchungy
samchungy commented Mar 19, 2023
View reviewed changes
template/private-npm-package/_package.json
"skuba": "*"
},
"engines": {
"node": ">=16.11"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only change is this

72636c
72636c approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@samchungy samchungy merged commit 71431e4 into master Mar 19, 2023
@samchungy samchungy deleted the node-16 branch March 19, 2023 08:39
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@72636c 72636c 72636c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samchungy @72636c