Skip to content

Commit

Permalink
Skip pre-build in Docker Compose service
Browse files Browse the repository at this point in the history
This should be generally faster across the pipelines, especially for
Gantry services that already have this covered with `gantry build`. A
caveat is that the Lambda deploy step may take a bit longer, but it's
probably good to have a safer npm `deploy` script and we know that we
need to revisit the speed of that pipeline soon anyway.
  • Loading branch information
72636c committed Sep 28, 2020
1 parent d246d85 commit ac102d8
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .changeset/two-trees-own.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'skuba': patch
---

**template:** Skip pre-build in Docker Compose service
2 changes: 1 addition & 1 deletion template/express-rest-api/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
args:
- NPM_READ_TOKEN
context: .
target: build
target: dev-deps
init: true
volumes:
- /workdir/node_modules
2 changes: 1 addition & 1 deletion template/greeter/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
args:
- NPM_READ_TOKEN
context: .
target: build
target: dev-deps
init: true
volumes:
- /workdir/node_modules
2 changes: 1 addition & 1 deletion template/koa-rest-api/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
args:
- NPM_READ_TOKEN
context: .
target: build
target: dev-deps
init: true
volumes:
- /workdir/node_modules
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
args:
- NPM_READ_TOKEN
context: .
target: build
target: dev-deps
environment:
- BUILDKITE_COMMIT
- ENVIRONMENT
Expand Down
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"private": true,
"scripts": {
"build": "skuba build",
"deploy": "serverless deploy --force --verbose",
"deploy": "yarn build && serverless deploy --force --verbose",
"format": "skuba format",
"lint": "skuba lint",
"test": "skuba test"
Expand Down

0 comments on commit ac102d8

Please sign in to comment.