Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fixtures Braid Version, Theme, and sku-init Template Enhancements #1092

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Update fixtures Braid Version, Theme, and sku-init Template Enhancements #1092

merged 15 commits into from
Nov 25, 2024

Conversation

adenj
Copy link
Contributor

@adenj adenj commented Nov 22, 2024

  • Bump Braid version: Update fixtures to use 33.1.0.
  • Switch theme: Replace apac theme with seekJobs.
  • Update sku-init template: Add prompts for installing sku-telemetry and shared-web-assets.
  • Refresh snapshots: Update to reflect changes.

@adenj adenj requested a review from a team as a code owner November 22, 2024 04:28
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2376ab4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

askoufis
askoufis approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 more comment on the template.

packages/sku/template/src/App/NextSteps.tsx Show resolved Hide resolved
@adenj adenj merged commit 6dab604 into master Nov 25, 2024
4 checks passed
@adenj adenj deleted the update-braid-fixtures branch November 25, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askoufis askoufis askoufis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adenj @askoufis