Skip to content

Commit

Permalink
Fixes a bug that caused React 19 applications to fail during `sku bui…
Browse files Browse the repository at this point in the history
…ld` (#1143)
  • Loading branch information
askoufis authored Jan 17, 2025
1 parent f9965a1 commit 8de3fd2
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 26 deletions.
7 changes: 7 additions & 0 deletions .changeset/great-gifts-hope.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'sku': patch
---

Fixes a bug that caused React 19 applications to fail during `sku build`

Note: remaining on React 18 is recommended until `sku` officially supports React 19. Updating your application to React 19 may require overriding dependency versions by configuring your package manager. Additionally, there may be other incompatibilities that haven't been found yet.
1 change: 0 additions & 1 deletion packages/sku/config/babel/babelConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ module.exports = ({

if (isProductionBuild) {
plugins.push(
require.resolve('@babel/plugin-transform-react-inline-elements'),
require.resolve('babel-plugin-transform-react-remove-prop-types'),
require.resolve('@babel/plugin-transform-react-constant-elements'),
);
Expand Down
1 change: 0 additions & 1 deletion packages/sku/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"dependencies": {
"@babel/core": "^7.21.8",
"@babel/plugin-transform-react-constant-elements": "^7.21.3",
"@babel/plugin-transform-react-inline-elements": "^7.21.0",
"@babel/plugin-transform-runtime": "^7.21.4",
"@babel/preset-env": "^7.21.5",
"@babel/preset-react": "^7.18.6",
Expand Down
24 changes: 0 additions & 24 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8de3fd2

Please sign in to comment.