Add "no-fallthrough" to base rules #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
switch
statements contain a break, return or throw in eachcase
. I believe most of the time engineers would intend for a case statement to not fallthrough to the next statement. Thus this eslint rule (which is part ofeslint:recommended
- see source) I'd say is a sensible default.Rule: https://eslint.org/docs/latest/rules/no-fallthrough