Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Prefer public family name to internal familyName metrics #191

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

michaeltaranto
Copy link
Contributor

@michaeltaranto michaeltaranto commented Apr 15, 2024

Ensure metrics are available using the public family name as seen on Google Fonts as opposed to the internal family name metric.
This makes sense as consumers are looking to import the metrics relevant to a specific system font or from Google Fonts (also aligns with the names Google use in their font declarations generated in the hosted stylesheets).

BREAKING CHANGES:

Google Fonts

Previously, the metrics were imported with a path that used the internal family name, now they align with the font as seen on Google Fonts.

-import metrics from '@capsizecss/metrics/roundedMplus1c';
+import metrics from '@capsizecss/metrics/mPLUSRounded1c';

With only a small number of Google Fonts affected, this is only a break for the following fonts:

  • Ballet
  • Bodoni Moda
  • Buda
  • Bungee Spice
  • Fjord One
  • Geologica
  • Imbue
  • M PLUS Rounded 1c
  • Material Symbols Outlined
  • Material Symbols Rounded
  • Material Symbols Sharp
  • Montagu Slab
  • Nanum Pen Script
  • Newsreader
  • Nunito Sans
  • Pathway Extreme
  • Sono
  • Sunflower
  • Supermercado One
  • Texturina

System fonts

The system fonts only had one example where the names diverged:

-import metrics from '@capsizecss/metrics/brushScriptMT';
+import metrics from '@capsizecss/metrics/brushScript';

This now aligns with the name consumers use to reference the font on their system.


Closes #189

@michaeltaranto michaeltaranto requested a review from a team as a code owner April 15, 2024 04:21
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 94bf3b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@capsizecss/metrics Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaeltaranto michaeltaranto merged commit d0086a6 into master Apr 15, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the prefer-google-font-name-to-metric-name branch April 15, 2024 04:32
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 15, 2024
michaeltaranto added a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for M PLUS Rounded 1c from Google Fonts
2 participants