Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuRenderer: refactor Badge bleed #1677

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

felixhabib
Copy link
Contributor

Refactoring Badge bleedY treatment. We get bleedY for free in a Text component, so removing the default Badge props. Also removing some flex properties which seems to create no diff.

@felixhabib felixhabib requested a review from a team as a code owner December 23, 2024 22:54
Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: 40a4249

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@michaeltaranto michaeltaranto merged commit cc41935 into master Dec 23, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the menurenderer-badge-bleedy branch December 23, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants