OverflowMenu: fix layout issue #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
askoufis
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1658 introduced
justifySelf: 'flex-end'onOverflowMenuto simplify its internal structure and ensure it would right align in its parent container regardless of the display property used.It looks like
justifySelffor block level boxes is only supported in Chrome 130+. Settingdisplay="flex"appears to make no difference.This Playroom will currently right align the content in Chromium browsers with version 130+ but not Safari or Firefox.
This change reintroduces a wrapper Box to ensure right alignment and no breaking change. It can be revisted in the future for a possible more elegant solution.
No changeset added because the change hasn't been published.