Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: advise not to use tone on text within Alert and Notice #1650

Closed
wants to merge 3 commits into from
Closed

RFC: advise not to use tone on text within Alert and Notice #1650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e019daf
Update Alert.docs.tsx
tadhglewis Nov 8, 2024
b499399
Update Notice.docs.tsx
tadhglewis Nov 8, 2024
f9fad21
Update Notice.docs.tsx
tadhglewis Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/braid-design-system/src/lib/components/Alert/Alert.docs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ const docs: ComponentDocs = {
This component has only been designed to use standard size text. Any
other size of text will break the alignment with the icon.
</Text>
<Text>
The tone should be set on the Alert component and not on the text as this will lead to inconsistent blending.
</Text>
Comment on lines +73 to +75
Copy link
Member Author

@tadhglewis tadhglewis Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to feedback as to the exact wording 🗯️

</Stack>
),
Example: () =>
Expand Down
3 changes: 3 additions & 0 deletions packages/braid-design-system/src/lib/components/Notice/Notice.docs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ const docs: ComponentDocs = {
This component has only been designed to use standard size text. Any
other size of text will break the alignment with the icon.
</Text>
<Text>
The tone should be set on the Notice component and not on the text as this will lead to inconsistent blending.
</Text>
</Stack>
),
Example: () =>
Expand Down
Loading