Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: Improve definition of preview path, fix double slash on root #1648

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

michaeltaranto
Copy link
Contributor

Centralising the definition of the preview path for deployments to a single env var. This makes it easier to update the path once centrally (e.g. the custom grad-connection site we maintain).

Also fixing a double slash on the production site link when on the root page.

@michaeltaranto michaeltaranto requested a review from a team as a code owner November 6, 2024 23:39
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 41805d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@michaeltaranto michaeltaranto merged commit 38c5ad4 into master Nov 6, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the preview-path-improvement branch November 6, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants