Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge: Ensure label follows correct tone #1544

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

michaeltaranto
Copy link
Contributor

Ensure that the foreground text of a Badge always follows the correct tone for the background colour.
Fixes a bug where using a Badge in a List that overrides the default tone would result in the Badge text following the List tone instead of the Badge tone.

@michaeltaranto michaeltaranto requested a review from a team as a code owner July 29, 2024 01:11
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 1dd6a50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaeltaranto michaeltaranto merged commit ff131ca into master Jul 29, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the fix-badge-default-tone-bug branch July 29, 2024 04:57
@seek-oss-ci seek-oss-ci mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants