Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix validate:dist dependency #1535

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

michaeltaranto
Copy link
Contributor

Fix build issue that attempts to validate circular dependencies in dist without entry point stubs being available. Ensuring dev has been run first enables the validation step to traverse the tree in dist.

Also switching pnpm to use workspace protocol in favour of overrides.

@michaeltaranto michaeltaranto requested a review from a team as a code owner July 17, 2024 00:29
Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 87efa36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@michaeltaranto michaeltaranto merged commit 5f9132e into master Jul 17, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the pnpm-workspace-fix branch July 17, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants