Tag: Introduce “addable” support #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d47bf69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
michaeltaranto
commented
Jun 26, 2024
| @@ -4,7 +4,7 @@ import { Tag, Inline, IconTag, Stack } from '../'; | |||
| import { debugTouchableAttrForDataProp } from '../private/touchable/debugTouchable'; | |||
|
|
|||
| export const screenshots: ComponentScreenshot = { | |||
| screenshotWidths: [320], | |||
| screenshotWidths: [768], | |||
There was a problem hiding this comment.
Increasing the screenshot width to avoid wrapping. Tag has no responsive behaviours and its more important to see alignment across variants horizontally.
michaeltaranto
commented
Jun 26, 2024
| ); | ||
|
|
||
| return { | ||
| code: code.replaceAll(': string', ''), |
There was a problem hiding this comment.
Stripping type information from the above example to ensure Playroom links work as expected
askoufis
approved these changes
Jun 27, 2024
packages/braid-design-system/src/lib/components/Tag/Tag.docs.tsx
Outdated
Show resolved
Hide resolved
michaeltaranto
commented
Jun 27, 2024
packages/braid-design-system/src/lib/components/Tag/Tag.docs.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Skoufis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag actions have been extended to now support being “added”.
A
Tagwill include a small add icon button when both anonAddhandler andaddLabelprop are provided.EXAMPLE USAGE:
Preview