Fix Animation handling in Modal component #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable for 'center' position - Opt out for backdrop
🦋 Changeset detectedLatest commit: 28ed583 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/braid-design-system/src/lib/components/private/Modal/Modal.tsx
Outdated
Show resolved
Hide resolved
packages/braid-design-system/src/lib/components/private/Modal/Modal.tsx
Outdated
Show resolved
Hide resolved
- Add exit animation for dialog - Refactor
packages/braid-design-system/src/lib/components/private/Modal/Modal.css.ts
Show resolved
Hide resolved
Co-authored-by: Michael Taranto <[email protected]>
michaeltaranto
approved these changes
May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
Modalcurrently has an exit transition, it looks like a fall-through in a switch statement has prevented this from ever showing.This change:
DrawerandDialogexit animationshorizontalTransitionDialogdocs page to add seperate state for the Dialog's width and open status