Prevent tabbing on checkboxes

seek-oss · Apr 17, 2024 · 13c262a · 13c262a
1 parent bf5b4c1
commit 13c262a
Show file tree

Hide file tree

Showing 2 changed files with 12,462 additions and 8,959 deletions.
diff --git a/packages/braid-design-system/src/lib/components/TagSelector/TagSelector.tsx b/packages/braid-design-system/src/lib/components/TagSelector/TagSelector.tsx
@@ -84,8 +84,9 @@ const TagOption = ({
           onClick={handleCheckboxClick}
           className={styles.TagOptionCheckbox}
           checked={checked}
-          aria-checked={checked}
           onChange={onSelect ? () => onSelect(tag) : undefined}
+          role="presentation"
+          tabIndex={-1}
         />
         <span>{tag.description}</span>
       </label>
@@ -244,9 +245,7 @@ export const TagSelector = ({
           aria-controls="available-tags"
           aria-autocomplete="list"
           aria-expanded="false"
-          data-active-option={`checkbox-${
-            dropdownOptions[getIndexOfActiveOption()]?.id
-          }`}
+          // Todo - potentially remove "checkbox-" prefix
           aria-activedescendant={`checkbox-${
             dropdownOptions[getIndexOfActiveOption()]?.id
           }`}