-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes an issue with dark modes, where observation "hi/Lo" color values (if specified) in skin.conf are not honored. #9
Conversation
…ss in skin.conf are not honored.
I noticed this the other day, updated the CSS and it's working fine, many thanks! The default blue doesn't look good against the dark theme background so I've adjusted the colour in the skin.con |
I would suggest changing the default lo_value_color in skin.conf to #4b94eb which can be read easily in both light and dark modes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default lo_value_color = blue does not look good in dark mode. Suggest changing skin.conf appearance section to:
# Here you can set a hex code for the text color of low / high values
# on all cards. By default they are grey. (quotes are needed on values)
# lo_value_color = "#03a9f4"
# hi_value_color = "#f44336"
lo_value_color = "#4b94eb"
hi_value_color = red
See review comments.
I'm struggling a bit with Github, it's not a platform I am very familiar with. There are two forks that have had recent activity, @W0CHP and @seehase, are these being merged? I am currently working on code for an interactive sun path diagram that gets the date, time and location from Weewx, when complete how do I get this on Github, do I create a new fork? |
Please enter a new PR for this. As this PR fixes a bug (vs. styling tweaks). Thanks! |
Addresses styling vs. fixing an issue in this PR
I agree with @seehausen |
Noticed that in dark mode, the "hi/lo" colors if defined in
skin.conf
are not honored/rendered. This minor PR fixes that.