Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.6.0 update #25

Merged
merged 3 commits into from
Feb 3, 2020
Merged

0.6.0 update #25

merged 3 commits into from
Feb 3, 2020

Conversation

David-OConnor
Copy link
Member

@MartinKavik is there anything else we need to change, ie to update the docs links?

MartinKavik
MartinKavik reviewed Feb 1, 2020
View reviewed changes
crate/src/lib.rs Outdated Show resolved Hide resolved
@MartinKavik MartinKavik mentioned this pull request Feb 3, 2020
Open
@MartinKavik
Copy link
Member

MartinKavik commented Feb 3, 2020 •
edited
Loading

  • You know docs more than I do (i.e. if content corresponds to new changes in changelog) and it looks like you did all steps related to this repo.
  • I don't have time to write/find linter for dead links (Broken links #17).
  • I don't want to add any other PRs.
  • So from my point of view it's ready.

@David-OConnor
Copy link
Member Author

David-OConnor commented Feb 3, 2020 •
edited
Loading

Sounds good. I was holding off for a chance to write the migration guide, but we can shelve that for this version, since I agree with you, don't have much time, and think the changelog's sufficient.

@David-OConnor David-OConnor merged commit f56f39b into master Feb 3, 2020
@David-OConnor David-OConnor deleted the 0.6.0 branch February 3, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinKavik MartinKavik MartinKavik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@David-OConnor @MartinKavik