-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List performance #1679
Merged
Merged
List performance #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burdiyan
reviewed
Mar 19, 2024
burdiyan
reviewed
Mar 19, 2024
juligasa
force-pushed
the
feat/list-perf
branch
from
March 25, 2024 09:48
9ba3c4f
to
515a2c4
Compare
horacioh
force-pushed
the
feat/list-perf
branch
from
March 28, 2024 15:12
1e7cc41
to
8d91ef0
Compare
horacioh
force-pushed
the
feat/list-perf
branch
from
March 29, 2024 20:58
8d91ef0
to
a8c9183
Compare
horacioh
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
horacioh
added a commit
that referenced
this pull request
Mar 29, 2024
* wip(daemon): recursive get publications * wip(daemon): add trusted only * wip(daemon): remove resource duplicates * wip(daemon): exclude drafts from listPublications * wip(daemon): remove children from tests * fix(daemon): Don't report drafts on listpublications * wip(daemon): list drafts * wip(daemon): include mentions * fix(daemon): account for untitled documents * fix(daemon): update migration to match schema * wip(daemon): page token on list drafts * wip(daemon): page token on list documents * implementing pagination in the frontend WIP * revert pagination in accounts model --------- Co-authored-by: Horacio Herrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed List drafts and ListPublications so that we get all the information directly from the database without having to iterate in code nor reading all blobs all the time.