fix(daemon): return empty list on unitialised keyring

seed-hypermedia · Jun 25, 2024 · cb21303 · cb21303
1 parent 838ca1e
commit cb21303
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/backend/core/keystore.go b/backend/core/keystore.go
@@ -139,7 +139,7 @@ func (ks *osKeyStore) ListKeys(ctx context.Context) ([]NamedKey, error) {
 
 	secret, err := keyring.Get(ks.serviceName, collectionName)
 	if err != nil {
-		return ret, errEmptyEnvironment
+		return ret, nil
 	}
 
 	collection := keyCollection{}

diff --git a/backend/core/keystore_test.go b/backend/core/keystore_test.go
@@ -39,7 +39,8 @@ func TestOSKeyStore(t *testing.T) {
 	emptyKey, err := ks.GetKey(ctx, "keyName")
 	require.Error(t, err)
 	keys, err := ks.ListKeys(ctx)
-	require.Error(t, err)
+	require.NoError(t, err)
+	require.Len(t, keys, 0)
 	require.NoError(t, ks.StoreKey(ctx, "keyName", kp))
 	key, err := ks.GetKey(ctx, "keyName")
 	require.NoError(t, err)