Support recursive wildcards in module ignores #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngnpope
force-pushed
the
recursive-wildcards
branch
2 times, most recently
from
22f2656 to
155b61d
Compare
This is a duplicate test case which is already in the "wildcards" section above. It shouldn't be under the "invalid expressions" section.
If the test failed to raise an exception as expected the test would silently pass. Fix this by using `pytest.raises()`.
Tests of the forbidden contract could be unstable where an invalid chain had multiple subchains.
ngnpope
force-pushed
the
recursive-wildcards
branch
from
155b61d to
806a598
Compare
seddonym
reviewed
Jun 6, 2023
|
|
||
| Examples: | ||
|
|
||
| - ``mypackage.*``: matches ``mypackage.foo`` but not ``mypackage.foo.bar``. | ||
| - ``mypackage.*.baz``: matches ``mypackage.foo.baz`` but not ``mypackage.foo.bar.baz``. | ||
| - ``mypackage.*.*``: matches ``mypackage.foo.bar`` and ``mypackage.foobar.baz``. | ||
| - ``mypackage.foo*``: not a valid expression. (The wildcard must replace a whole module name.) | ||
| - ``mypackage.**``: matches ``mypackage.foo.bar`` and ``mypackage.foobar.baz``. |
There was a problem hiding this comment.
Should this be mypackage.foo.bar.baz?
There was a problem hiding this comment.
Well, no, I guess it was highlighting that it'd give the same as mypackage.*.*, but I guess also anything below that too. A bit of a tricky one to express sanely.
seddonym
approved these changes
Jun 7, 2023
| @@ -138,10 +138,6 @@ class TestModuleField(BaseFieldTest): | |||
| "mypackage.**.bar -> mypackage.baz", | |||
| ValidationError("A wildcard can only replace a whole module."), | |||
| ), | |||
| ( | |||
| @@ -33,11 +34,9 @@ class BaseFieldTest: | |||
| def test_field(self, raw_data, expected_value): | |||
| field = self.field_class(**self.field_kwargs) | |||
|
|
|||
| if isinstance(expected_value, ValidationError): | |||
| try: | |||
| if isinstance(expected_value, Exception): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160.