Implement a "multi layer" contract #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A form of hybrid contract between 'layers' and 'independence'. Where modules declared on the same level are independent from each other while they individually honor their "lower layers".
|
Oh, and it should pass on |
|
Thanks so much for this, very cool! I'll have a close look when I come to implement independence within layers. I don't think I'll merge it in its form as a distinct contract type as I think it should be wrapped up within the existing contract type. So I'm going to close it, but it's helpful as a reference point. |
|
Cool, I'd agree with you combining it with some existing contract type. It feels like it could be a natural extension to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A form of hybrid contract between 'layers' and 'independence'. Where modules declared on the same level are independent from each other while they individually honor their "lower layers".
(Hopefully) Fixes #157
This is just a port of a contract I created for one of our projects quite a while ago. I tried to hook it up in to the test suite a bit. I can barely recall the approach taken in here. But could refresh my mind if the contract is of interest.
Feel free to do what you want with it, if only for inspiration. I didn't bother resolving any type checking or other CI fixes until it would be of interest to merge.