Support wildcards in module ignores (#103) #106
Conversation
seddonym
force-pushed
the
wildcards
branch
2 times, most recently
from
58424fa to
6ce03c8
Compare
docs/contract_types.rst
Outdated
| @@ -2,25 +2,6 @@ | |||
| Contract types | |||
| ============== | |||
|
|
|||
| .. _Shared options: | |||
There was a problem hiding this comment.
I thought this worked better at the bottom.
| @@ -136,7 +136,35 @@ def test_ignore_imports_tolerates_duplicates(self): | |||
| ), | |||
| include_external_packages=False, | |||
| ) | |||
| assert contract.check(graph=graph) | |||
There was a problem hiding this comment.
This was a bug in the test, corrected.
| @@ -15,6 +15,34 @@ | |||
| (testpackage_directory, ".brokencontract.ini", cli.EXIT_STATUS_ERROR), | |||
| (testpackage_directory, ".malformedcontract.ini", cli.EXIT_STATUS_ERROR), | |||
| (testpackage_directory, ".customkeptcontract.ini", cli.EXIT_STATUS_SUCCESS), | |||
| (testpackage_directory, ".externalbrokencontract.ini", cli.EXIT_STATUS_ERROR), | |||
There was a problem hiding this comment.
I've reordered the tests here so that the TOML ones were together. I also added a couple of tests for the TOML version of setup.cfg so we can make sure the wildcards are ok in that format.
|
Dear oh dear, Travis builds have stopped working because I have run out of credits. I thought it was free for open source. I have contacted Travis support but by the sound of it I might be waiting a long time, we'll see. |
|
@kasium fancy giving this a review? I have squashed your original work into the first commit and have added tests (and a couple of tweaks). |
|
So I looked thru it and it seems fine to me |
|
Great, thanks! This is now only blocked by Travis CI so hopefully they will get back to me soon. |
Support wildcards in module ignores
|
Travis actually got back to me same day 🥳 |
|
This is now released in Import Linter version 1.2.5. Thanks again for all your help. |
|
Thanks a lot 😄 |
This supports the use of wildcards in the
ignore_importsof contracts.