Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action): unify focus state #834

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat(action): unify focus state #834

merged 1 commit into from
Oct 18, 2023

Conversation

ajkl2533
Copy link
Contributor

This PR unifies the focus state across most interactive elements (buttons, links, tabs...) and sets the focus in a global way so we do not need to set it for each component separately.

This will provide:

  1. less confusion for our users with a unified experience
  2. lesser complexity and better maintain via one global styling

BEFORE

Screenshot 2023-10-10 at 17 30 08 Screenshot 2023-10-10 at 17 30 27 Screenshot 2023-10-10 at 17 30 58

AFTER

Screenshot 2023-10-10 at 17 33 19 Screenshot 2023-10-10 at 17 33 36 Screenshot 2023-10-10 at 17 33 47

Closes UXD-1260

@ajkl2533 ajkl2533 merged commit b92aef8 into main Oct 18, 2023
17 checks passed
@ajkl2533 ajkl2533 deleted the ajkl2533@UXD-1260 branch October 18, 2023 11:04
@github-actions
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnau-mnau Mnau-mnau Mnau-mnau approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajkl2533 @Mnau-mnau